Support running integration tests against locally built images - #85
Merged
Conversation
oysand
force-pushed
the
local-images
branch
4 times, most recently
from
August 5, 2026 07:23
e7087a3 to
972b589
Compare
Eddasol
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the local-image support out of #83 so it can be reviewed and merged on its own.
Running the integration tests against locally built service images was previously impossible: the images are pulled from
ghcr.io, so a change spanning armada and one of the services could not be verified until the service change was merged and published — even though the armada side is what proves the service side works.This adds:
scripts/build_local_images.sh— buildsflotilla,sara,isarandisar-robotfrom local checkouts, verifies each image, and optionally runs the suite against them.isar-robotis cloned rather than built from the working tree, because its Dockerfile bind-mounts.git, which is a submodule file in the superrepo.MIGRATIONS_SOURCE_DIR/SARA_MIGRATIONS_SOURCE_DIR— takes the database schema from the same local checkouts, so application code and schema agree. The directory is mounted read-only and copied into the migrations container, so uncommitted and untracked migrations are included.bin/objare excluded deliberately: they are host-architecture output andobj/project.assets.jsonholds absolute host paths, either of which breaks restore inside the container.build_image_once()— a cross-process file lock around building images from local Dockerfiles.DockerImage(...).build()is called per test, so under-n autoa dozen workers build the same tag at once and the losers fail with "already exists, but accessing it also failed". The layer cache normally hides this; it appears the moment one of those images is edited.Defaults are unchanged — with neither
*_SOURCE_DIRset, the behaviour is exactly as before.Verification
test_simple_mission_is_successfulpasses unchanged (published images, cloned migrations).MIGRATIONS_SOURCE_DIRandSARA_MIGRATIONS_SOURCE_DIRpointed at local checkouts, exercising the new copy path.Note for reviewers
#83 is stacked on this branch. Because it is a cross-fork PR its base cannot point here, so it will keep showing these three commits until this one merges; rebasing it onto
mainafterwards drops them automatically.